Re: [PATCH] mtd: rawnand: marvell: prevent harmless warnings

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Mon, 10 Sep 2018 15:15:23 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> Hi Boris,
> 
> Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Mon, 10 Sep 2018
> 14:57:44 +0200:
> 
> > On Fri,  7 Sep 2018 16:29:54 +0200
> > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >   
> > > Since the addition of WARN_ON() in nand_subop_get_data/addr_len()
> > > helpers, this driver will produce harmless warnings (mostly at probe)
> > > just because it always called the *_data_len() helper in the parsing    
> > 
> > 			 ^calls
> >   
> > > function (even on non-data instructions, where this value is
> > > meaningless and unneeded.    
> > 
> > 			  ^ missing ')'
> >   
> > > 
> > > Fix these warnings by deriving the length only when it is relevant.
> > > 
> > > Fixes: 760c435e0f85 ("mtd: rawnand: make subop helpers return unsigned values")
> > > Cc: stable@xxxxxxxxxxxxxxx    
> > 
> > You can drop the above line this 760c435e0f85 was merged in 4.19-rc1.
> > 
> > If you're okay with these changes, no need to send a new version, I'll
> > fix it when applying.  
> 
> Sure, you can apply, thanks for fixing it.

Queued to master.

Thanks,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/