Hi Miquel,
thanks for your review, I've applied most of your suggested changes,
except:
On 06/09/18 20:47, Miquel Raynal wrote:
+static int virt_concat_remove(struct platform_device *pdev)
+{
+ struct of_virt_concat *info;
+ int i;
+
+ info = platform_get_drvdata(pdev);
+ if (!info)
+ return 0;
+ platform_set_drvdata(pdev, NULL);
Is this really useful?
I believe this is indeed useful, as `virt_concat_remove()` is also
called as cleanup in error cases of `virt_concat_probe()`. Then it seems
to be common practice to unset the driver data from the device.
Am I mistaken here?
Best regards
Bernhard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
