Re: [PATCH v2] mtd: nand: use regmap_update_bits() in marvell_nand for syscon access

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Thomas,

Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote on Thu,  2 Aug
2018 10:56:25 +0200:

> The marvell_nfc_init() function fiddles with some bits of a system
> controller on Armada 7K/8K. However, it does a read/modify/write
> sequence on GENCONF_CLK_GATING_CTRL and GENCONF_ND_CLK_CTRL, which
> isn't safe from a concurrency point of view, as the regmap lock isn't
> taken accross the read/modify/write sequence. To solve this issue, use
> regmap_update_bits().
> 
> While at it, since the "reg" variable is no longer needed for the
> read/modify/write sequences, get rid of it for the regmap_write() to
> GENCONF_SOC_DEVICE_MUX, and directly pass the value to be written as
> argument.
> 
> Fixes: 02f26ecf8c772 ("mtd: nand: add reworked Marvell NAND controller driver")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>
> ---

Applied to nand/next with the subject prefix changed to
"mtd: rawnand: marvell:"

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/