Re: [PATCH] spi-nor: intel-spi: Add support for Intel Ice Lake SPI serial flash

[Marek Vasut <marek.vasut@xxxxxxxxx>]

On 08/28/2018 06:59 PM, Mika Westerberg wrote:
> On Tue, Aug 28, 2018 at 06:56:38PM +0200, Marek Vasut wrote:
>> On 08/28/2018 06:50 PM, Mika Westerberg wrote:
>>> Intel Ice Lake exposes the SPI serial flash controller as a PCI device
>>> in the same way than Intel Denverton. Add Ice Lake SPI serial flash PCI
>>> ID to the driver list of supported devices.
>>>
>>> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>>
>> This should probably go through trivial patches ML, no ?
> 
> Hmm, what do you mean? This is not a typo fix or similar but adds a new
> PCI ID to the driver.

I mean, adding PCI IDs might be considered trivial. But if you want it
to go through MTD, fine:

Acked-by: Marek Vasut <marek.vasut@xxxxxxxxx>

>> Also, CC Stable.
> 
> OK.
> 
>>> ---
>>>  drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
>>> index c0976f2e3dd1..872b40922608 100644
>>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>>> @@ -65,6 +65,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>>  static const struct pci_device_id intel_spi_pci_ids[] = {
>>>  	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>>  	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>> +	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>>  	{ PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
>>>  	{ PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
>>>  	{ },
>>>
>>
>>
>> -- 
>> Best regards,
>> Marek Vasut


-- 
Best regards,
Marek Vasut

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/