Re: [PATCH] mtd: rawnand: qcom: don't include dma-direct.h

[Richard Weinberger <richard.weinberger@xxxxxxxxx>]

On Mon, Aug 27, 2018 at 10:59 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> A recent commit removed the incorrect use of phys_to_dma from this
> driver, but failed to remove the dma-direct.h include, so do that
> now.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  drivers/mtd/nand/raw/qcom_nandc.c | 1 -
>  include/linux/dma-mapping.h       | 6 ++++++
>  2 files changed, 6 insertions(+), 1 deletion(-)

Hmm, the diffstat does not match the diff itself.

> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index d1d470bb32e4..d2831b0b28fb 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -23,7 +23,6 @@
>  #include <linux/of_device.h>
>  #include <linux/delay.h>
>  #include <linux/dma/qcom_bam_dma.h>
> -#include <linux/dma-direct.h> /* XXX: drivers shall never use this directly! */
>
>  /* NANDc reg offsets */
>  #define        NAND_FLASH_CMD                  0x00
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/