[PATCH] mtd: rawnand: s3c2410: Error out when ->nrsets < 0 or ->sets == NULL

[boris.brezillon@xxxxxxxxxxx (Boris Brezillon)]

On Thu, 19 Jul 2018 13:30:47 +0300
Dan Carpenter <dan.carpenter at oracle.com> wrote:

> On Thu, Jul 19, 2018 at 11:41:37AM +0200, Boris Brezillon wrote:
> > @@ -1152,7 +1157,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)
> >  
> >  	nmtd = info->mtds;
> >  
> > -	for (setno = 0; setno < nr_sets; setno++, nmtd++) {
> > +	for (setno = 0; setno < nr_sets; setno++, nmtd++, sets++) {
> >  		struct mtd_info *mtd = nand_to_mtd(&nmtd->chip);
> >  
> >  		pr_debug("initialising set %d (%p, info %p)\n",
> > @@ -1174,9 +1179,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)  
> 
> Can you also remove the NULL check from int the middle of the loop:
> 
> 		err = nand_scan_ident(mtd, (sets) ? sets->nr_chips : 1, NULL);

Sure.

>                                             ^^^^
> 
> >  			goto exit_error;
> >  
> >  		s3c2410_nand_add_partition(info, nmtd, sets);
> > -
> > -		if (sets != NULL)
> > -			sets++;
> >  	}  
> 
> regards,
> dan carpenter
>