On Thu, 19 Jul 2018 01:12:32 +0200 Miquel Raynal <miquel.raynal at bootlin.com> wrote: > Hello, > > After having sent two versions of a series removing the > nand_scan_ident/nand_scan_tail limitation that prevents us to allocate > memory at critical moments, we are still discussing the internal API. > > To avoid sending again more than 20 patches, this is an RFC of the > internal changes prior to the above modifications in each driver: > > 1/ Rename struct nand_hw_control -> struct nand_controller which is > much more meaningful. > 2/ Rename the function initializing the above structure > nand_hw_control_init() -> nand_controller_init(). > 3/ Rename the dummy controller implementation in the nand_chip structure > hwcontrol -> dummy_controller. > 3/ Create a nand_controller_ops structure which will be embedded in the > nand_controller structure. These operations are: > int (*attach_chip)(struct nand_chip *) and > void (*detach_chip)(struct nand_chip *). > > If we agree on this, I could merge them first and then send the bunch of > patches making use of these API changes. > This version looks good to me. Regards, Boris