Hi Boris, Boris Brezillon <boris.brezillon at bootlin.com> wrote on Tue, 17 Jul 2018 13:49:50 +0200: > On Tue, 17 Jul 2018 11:54:52 +0200 > Miquel Raynal <miquel.raynal at bootlin.com> wrote: > > > In the raw NAND core, a NAND chip is described by a nand_chip structure, > > while a NAND controller is described with a nand_hw_control structure > > which is not very meaningful. 'control' is misleading and 'hw' has no > > meaning here has it refers to hardware ECC operations only, > > I don't think hw refers to hardware ECC, but I agree that > nand_controller is a better name for this structure. > > How about dropping the last sentence? Do you mean, removing "'control' is misleading [...] which is too restrictive" or "Rename this structure nand_controller" ? > > > which is too > > restrictive. > > > > Rename this structure nand_controller. > > > > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com> > > Acked-by: Boris Brezillon <boris.brezillon at bootlin.com> >