On Saturday, July 07, 2018 05:48 PM, Miquel Raynal wrote: > Daniel Mack <daniel at zonque.org> wrote on Sat, 7 Jul 2018 08:46:29 > +0200: >> + writel_relaxed(NDCR_ALL_INT | NDCR_ND_ARB_EN | NDCR_SPARE_EN | >> + NDCR_RD_ID_CNT(NFCV1_READID_LEN), nfc->regs + NDCR); >> + writel_relaxed(0xFFFFFFFF, nfc->regs + NDSR); >> + writel_relaxed(0, nfc->regs + NDECCCTRL); > > This is an exact copy of a few lines from marvell_nfc_init(). > What about creating an helper called > marvell_nfc_init_core_registers(nfc) that would be called twice? Sure, why not. Will send a v4 for that. Thanks, Daniel