Hi Miquel, On Sat, Jul 7, 2018 at 2:00 PM, Miquel Raynal <miquel.raynal at bootlin.com> wrote: >> +// SPDX-License-Identifier: GPL-2.0+ >> +// >> +// Freescale GPMI NAND Flash Driver >> +// >> +// Copyright (C) 2008-2011 Freescale Semiconductor, Inc. >> +// Copyright (C) 2008 Embedded Alley Solutions, Inc. > > Maybe I'm not aware of something recent but I thought only the SPDX > license tag was supposed to use '//' comments while the other lines > should be still using '/* */' like any other comments in the code? There are some subsystem maintainers (and also Linus) that prefer putting everything in // style: https://lkml.org/lkml/2017/11/25/133 > I think the rest of this subsystem uses: > > // SPDX tag > /* > * > [...] > */ > > Would you mind changing this? Sure, I can send a v2.