[PATCH 3/3] mtd: rawnand: marvell: add suspend and resume hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Boris,

On Saturday, July 07, 2018 08:07 AM, Boris Brezillon wrote:
> On Sat, 7 Jul 2018 00:26:22 +0200
> Daniel Mack <daniel at zonque.org> wrote:

>> Ah, I only see this now, but patch 2 also fixes a problem with the
>> .remove() callback of this driver which also blindly grabs ->reg_clk
>> without further checks.
> 
> Nope, because the clk framework checks for both ERR and NULL (see
> [1]). I'm definitely not arguing that patch 2 is not needed (actually I
> pushed for this solution when Greg initially added these new clks [2]),
> just that it should not be flagged as stable.

Ah, I missed that! Sorry.

>> Hence the entire series actually qualifies for stable@ I figure?
> 
> I'd really prefer to have a single patch go into stable. Patch 1 is
> clearly not a bug fix, and patch 2 is just a dependency of patch 3, so
> let's remove this dependency by either squashing both patches into a
> single one or by reordering the changes.

Okay then. Hang on, I'll send a v2.


Thanks,
Daniel



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux