Patch "mtd: cfi_cmdset_0002: Change write buffer to check correct value" has been added to the 4.17-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    mtd: cfi_cmdset_0002: Change write buffer to check correct value

to the 4.17-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch
and it can be found in the queue-4.17 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable at vger.kernel.org> know about it.


>From dfeae1073583dc35c33b32150e18b7048bbb37e6 Mon Sep 17 00:00:00 2001
From: Tokunori Ikegami <ikegami@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 30 May 2018 18:32:26 +0900
Subject: mtd: cfi_cmdset_0002: Change write buffer to check correct value

From: Tokunori Ikegami <ikegami@xxxxxxxxxxxxxxxxxxxx>

commit dfeae1073583dc35c33b32150e18b7048bbb37e6 upstream.

For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word.
Since it is described by data sheets to check the operation status.

Signed-off-by: Tokunori Ikegami <ikegami at allied-telesis.co.jp>
Reviewed-by: Joakim Tjernlund <Joakim.Tjernlund at infinera.com>
Cc: Chris Packham <chris.packham at alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace at gmail.com>
Cc: David Woodhouse <dwmw2 at infradead.org>
Cc: Boris Brezillon <boris.brezillon at free-electrons.com>
Cc: Marek Vasut <marek.vasut at gmail.com>
Cc: Richard Weinberger <richard at nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen at wedev4u.fr>
Cc: linux-mtd at lists.infradead.org
Cc: stable at vger.kernel.org
Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

---
 drivers/mtd/chips/cfi_cmdset_0002.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1880,7 +1880,7 @@ static int __xipram do_write_buffer(stru
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}


Patches currently in stable-queue which might be from ikegami at allied-telesis.co.jp are

queue-4.17/mtd-cfi_cmdset_0002-change-erase-functions-to-retry-for-error.patch
queue-4.17/mtd-cfi_cmdset_0002-change-write-buffer-to-check-correct-value.patch
queue-4.17/mips-bcm47xx-enable-74k-core-externalsync-for-pcie-erratum.patch



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux