On Mon, 2017-05-29 at 19:16 +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 11:17:06AM -0700, Ricardo Neri wrote: > > The function get_reg_offset() returns the offset to the register the > > argument specifies as indicated in an enumeration of type offset. Callers > > of this function would need the definition of such enumeration. This is > > not needed. Instead, add helper functions for this purpose. These functions > > are useful in cases when, for instance, the caller needs to decide whether > > the operand is a register or a memory location by looking at the rm part > > of the ModRM byte. As of now, this is the only helper function that is > > needed. > > > > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> > > Cc: Adam Buchbinder <adam.buchbinder@xxxxxxxxx> > > Cc: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Cc: Lorenzo Stoakes <lstoakes@xxxxxxxxx> > > Cc: Qiaowei Ren <qiaowei.ren@xxxxxxxxx> > > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > > Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx> > > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > Cc: Kees Cook <keescook@xxxxxxxxxxxx> > > Cc: Thomas Garnier <thgarnie@xxxxxxxxxx> > > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > Cc: Borislav Petkov <bp@xxxxxxx> > > Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx> > > Cc: Ravi V. Shankar <ravi.v.shankar@xxxxxxxxx> > > Cc: x86@xxxxxxxxxx > > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx> > > --- > > arch/x86/include/asm/insn-eval.h | 1 + > > arch/x86/lib/insn-eval.c | 15 +++++++++++++++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/arch/x86/include/asm/insn-eval.h b/arch/x86/include/asm/insn-eval.h > > index 5cab1b1..7e8c963 100644 > > --- a/arch/x86/include/asm/insn-eval.h > > +++ b/arch/x86/include/asm/insn-eval.h > > @@ -12,5 +12,6 @@ > > #include <asm/ptrace.h> > > > > void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs); > > +int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs); > > > > #endif /* _ASM_X86_INSN_EVAL_H */ > > diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c > > index 182e2ae..8b16761 100644 > > --- a/arch/x86/lib/insn-eval.c > > +++ b/arch/x86/lib/insn-eval.c > > @@ -97,6 +97,21 @@ static int get_reg_offset(struct insn *insn, struct pt_regs *regs, > > return regoff[regno]; > > } > > > > +/** > > + * insn_get_reg_offset_modrm_rm() - Obtain register in r/m part of ModRM byte > > That name needs to be synced with the function name below. Ugh! I missed this. I will update accordingly. Thanks for the detailed review. BR, Ricardo -- To unsubscribe from this list: send the line "unsubscribe linux-msdos" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
