Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ricardo Neri <ricardo.neri-calderon@xxxxxxxxxxxxxxx>
Subject: Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
From: Borislav Petkov <bp@xxxxxxx>
Date: Sun, 7 May 2017 19:20:50 +0200
Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Huang Rui <ray.huang@xxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Chen Yucong <slaoub@xxxxxxxxx>, Alexandre Julliard <julliard@xxxxxxxxxx>, Stas Sergeev <stsp@xxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-msdos@xxxxxxxxxxxxxxx, wine-devel@xxxxxxxxxx, Adam Buchbinder <adam.buchbinder@xxxxxxxxx>, Colin Ian King <colin.king@xxxxxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, Qiaowei Ren <qiaowei.ren@xxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Thomas Garnier <thgarnie@xxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>
In-reply-to: <1493256599.36058.83.camel@ranerica-desktop>
List-id: <linux-msdos.vger.kernel.org>
References: <20170308003254.27833-1-ricardo.neri-calderon@linux.intel.com> <20170308003254.27833-11-ricardo.neri-calderon@linux.intel.com> <20170421105258.q4vqrephtm7t3h4c@pd.tnic> <1493256599.36058.83.camel@ranerica-desktop>
Sender: linux-msdos-owner@xxxxxxxxxxxxxxx
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Apr 26, 2017 at 06:29:59PM -0700, Ricardo Neri wrote:
> > 	if (X86_MODRM_MOD(insn->modrm.value) == 0 &&
> > 	    X86_MODRM_RM(insn->modrm.value)  == 5)
> > 
> > looks more understandable to me.
> 
> Should I go with !(X86_MODRM_MOD(insn->modrm.value)) as you suggested in
> other patches?

Ah, yes pls.

Thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-msdos" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
  - From: Ricardo Neri

References:
- [v6 PATCH 00/21] x86: Enable User-Mode Instruction Prevention
  - From: Ricardo Neri
- [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
  - From: Ricardo Neri
- Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
  - From: Borislav Petkov
- Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
  - From: Ricardo Neri

Prev by Date: Re: [PATCH v7 20/26] x86/cpufeature: Add User-Mode Instruction Prevention definitions
Next by Date: Re: [v6 PATCH 12/21] x86/insn: Support both signed 32-bit and 64-bit effective addresses
Previous by thread: Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
Next by thread: Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
Index(es):
- Date
- Thread

[Index of Archives] [Linux Console] [Linux Audio] [Linux for Hams] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Yosemite Camping] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID] [Samba] [Linux Media] [Fedora Users]