On Wed, Feb 22, 2017 at 10:36:50PM -0800, Ricardo Neri wrote: > + /* > + * A negative offset generally means a error, except > + * -EDOM, which means that the contents of the register > + * should not be used as index. > + */ > if (indx_offset < 0) > - goto out_err; > + if (indx_offset == -EDOM) > + indx = 0; > + else > + goto out_err; > + else > + indx = regs_get_register(regs, indx_offset); Kernel coding style requires more brackets than are strictly required by C, any block longer than 1 line needs then. Also, if one leg of a conditional needs them, then they should be on both legs. Your code has many such instances, please change them all. -- To unsubscribe from this list: send the line "unsubscribe linux-msdos" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
