On Fri, Jan 03, 2025 at 05:13:32PM +0100, Petr Pavlu wrote: > On 12/5/24 20:46, Christophe Leroy wrote: > > This series reworks module loading to avoid leaving the module in a > > stale state when protecting ro_after_init section fails. > > > > Once module init has succeded it is too late to cancel loading. Is there at least a big WARN about the ro failing? That should let more sensitive system owners react to the situation if it looks like an active attack on memory protections. (And maybe we should set a TAINT flag, but perhaps this is too specific a failure mode for that?) Also, why is it too late to cancel? Can we set the module to the "Unloading" state to stop any dependent modules from loading on top of it, and then request it unload? -- Kees Cook