Re: [PATCH v7 02/18] gendwarfksyms: Add address matching

[Masahiro Yamada <masahiroy@xxxxxxxxxx>]

On Fri, Dec 20, 2024 at 6:07 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> diff --git a/scripts/gendwarfksyms/symbols.c b/scripts/gendwarfksyms/symbols.c
> index 7adf2ed9b89b..98febb524dd5 100644
> --- a/scripts/gendwarfksyms/symbols.c
> +++ b/scripts/gendwarfksyms/symbols.c
> @@ -6,8 +6,39 @@
>  #include "gendwarfksyms.h"
>
>  #define SYMBOL_HASH_BITS 12
> +
> +/* struct symbol_addr -> struct symbol */
> +static HASHTABLE_DEFINE(symbol_addrs, 1 << SYMBOL_HASH_BITS);
> +/* name -> struct symbol */

I think this comment addition should belong to 01/18 instead of 02/18.


>  static HASHTABLE_DEFINE(symbol_names, 1 << SYMBOL_HASH_BITS);





-- 
Best Regards
Masahiro Yamada