On Thu, Nov 28, 2024 at 11:42 AM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > Now with Masahiro's cleanups, in my testing we don't need the FORCE anymore. > > > From 83497e0e83d81950df54d82461b1dae629842147 Mon Sep 17 00:00:00 2001 > From: Luis Chamberlain <mcgrof@xxxxxxxxxx> > Date: Wed, 27 Nov 2024 14:10:57 -0800 > Subject: [PATCH v3] selftests: kallsyms: fix double build stupidity > > Fix the stupid FORCE so that re-builds will only trigger > when really needed. While at it, document the sensible ranges > supported and fix the script to accept these alternatives. > > Also adopt Masahiro Yamada's suggested cleanups on the Makefile. > > Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> Did you run any compile-test before submitting this? if_changed requires FORCE. Your patch introduces new warnings. mkdir -p /home/masahiro/ref/linux/tools/objtool && make O=/home/masahiro/ref/linux subdir=tools/objtool --no-print-directory -C objtool INSTALL libsubcmd_headers CALL scripts/checksyscalls.sh lib/tests/module/Makefile:12: FORCE prerequisite is missing GEN lib/tests/module/test_kallsyms_a.c lib/tests/module/Makefile:12: FORCE prerequisite is missing lib/tests/module/Makefile:12: FORCE prerequisite is missing GEN lib/tests/module/test_kallsyms_b.c lib/tests/module/Makefile:12: FORCE prerequisite is missing GEN lib/tests/module/test_kallsyms_c.c GEN lib/tests/module/test_kallsyms_d.c CC [M] lib/tests/module/test_kallsyms_a.o CC [M] lib/tests/module/test_kallsyms_b.o CC [M] lib/tests/module/test_kallsyms_c.o CC [M] lib/tests/module/test_kallsyms_d.o -- Best Regards Masahiro Yamada
