On Mon, Nov 18, 2024 at 01:54:14PM +0100, Petr Pavlu wrote:
> I'm however not sure about rejecting empty strings as is also done by
> the patch. Consider a call to request_module("mod%s", suffix) where the
> suffix could be empty to select the default variant, or non-empty to
> select e.g. some optimized version of the module. Only the caller knows
> if the suffix being empty is valid or not.
>
> I've checked if this pattern is currently used in the kernel and wasn't
> able to find anything, so that is good. However, I'm not sure if
> request_module() should flat-out reject this use.
This patch also fails to pass a simple boot test with our Linux kernel
modules CI:
https://github.com/linux-kdevops/kdevops/blob/main/docs/kernel-ci/linux-modules-kdevops-ci.md
https://patchwork.kernel.org/project/linux-modules/patch/20241110114233.97169-1-chensong_2000@xxxxxx/
For persistent results see this and download the tarball for results:
https://github.com/search?q=repo%3Alinux-kdevops%2Fkdevops-results-archive+is%3Acommit+%22linux-modules-kpd%3A%22&type=commits
So please boot test any future patch before posting and make sure its
based on modules-next:
https://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git/
modules-next
You can reproduce yourself with kdevops [0]:
make selftests-modules
make -j80
make bringup
make linux # it fails here with your patch applied
make selftests-baseline
For a more elaborate description of our CI setup:
https://github.com/linux-kdevops/kdevops/blob/main/docs/kernel-ci/README.md
[0] https://github.com/linux-kdevops/kdevops
Luis
