On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> To avoid duplication between host programs, move the crc32 code to a
> shared header file.
Only the motivation to use this long table is to keep compatibility
between genksyms and gendwarfksyms.
I do not think this should be exposed to other programs.
If you avoid the code duplication, you can do
// scripts/gendwarfksyms/crc.c
#include "../genksyms/crc.c"
>
> Suggested-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Acked-by: Neal Gompa <neal@xxxxxxxxx>
Does this Ack add any value?
Acked-by is meaningful only when it is given by someone who
maintains the relevant area or has established a reputation.
$ git grep "Neal Gompa"
$ git shortlog -n -s | grep "Neal Gompa"
2 Neal Gompa
His Ack feels more like "I like it" rather than a qualified endorsement.
--
Best Regards
Masahiro Yamada
