So, the basic things I can think of to test here are: 1. The kernel can still load the previous MODVERSIONS format 2. The kernel can load the new MODVERSIONS format 3. If we artificially tweak a CRC in the previous format, it will fail to load. 4. If we artificially tweak a CRC in the new format, it will fail to load. 5. With CONFIG_EXTENDED_MODVERSIONS enabled, the kernel will build and load modules with long symbol names, with MODVERSIONS enabled. Is there anything else you were thinking of here, or are those the kinds of checks you were envisioning? On Fri, Oct 11, 2024 at 4:46 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > On Fri, Oct 11, 2024 at 04:45:25PM -0700, Luis Chamberlain wrote: > > > > Also, just as I asked Sami, coould you split this up into patch sets? > > One with all the cleanups and elf validation code shifts. And then the > > other code. That will let me pick up quickly the first patch set. > > Oh and if you can think of ways to enhance our test covereage on all > this as I noted to Sami, it would be greatly appreciated. > > Luis
