On Wed, Sep 11, 2024 at 11:28:02AM +0800, Chunhui Li wrote: > When insmod a kernel module, if fails in add_notes_attrs or > add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup > will still return success, but we can't access user interface > on android device. > > Patch for make mod_sysfs_setup can check the error of > add_notes_attrs and add_sysfs_attrs > > Fixes: db939b519bea ("Module section offsets in /sys/module") > Fixes: 6d76013381ed ("Add /sys/module/name/notes") > Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> > Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202409010016.3XIFSmRA-lkp@xxxxxxxxx/ > Closes: https://lore.kernel.org/oe-kbuild-all/202409072018.qfEzZbO7-lkp@xxxxxxxxx/ > Signed-off-by: Xion Wang <xion.wang@xxxxxxxxxxxx> > Signed-off-by: Chunhui Li <chunhui.li@xxxxxxxxxxxx> Applied and pushed! I modified the commit log slighlty to fix the commit referelcen to the first issue with sections as that is part linux history.git. [0] https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=3f7b0672086b97b2d7f322bdc289cbfa203f10ef Luis