On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg <nmi@xxxxxxxxxxxx> wrote: > > "Trevor Gross" <tmgross@xxxxxxxxx> writes: > > > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg <nmi@xxxxxxxxxxxx> wrote: > >> > >> From: Andreas Hindborg <a.hindborg@xxxxxxxxxxx> > >> > >> This patch includes changes required for Rust kernel modules to utilize > >> module parameters. This code implements read only support for integer > >> types without `sysfs` support. > > > > Also, I think the subject line needs an update ("rust: add > > `module_params` macro") > > Well, it is still what it does. Plus few support types. You think it is > not descriptive enough? Maybe it should just say 'Add parameter support to the `module!` macro'? The text `module_params` doesn't seem to appear in the patch, I was looking for something like `module_params!`. - Trevor > BR Andreas