On Fri, 19 Jul 2024 at 23:13, Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> wrote: > > Drop the lengthy license from each file and just use SPDX like most > projects nowadays. > Massive +1 for the idea, I should go and update some of my other projects. > Signed-off-by: Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> > --- <snip> > --- a/libkmod/libkmod-config.c > +++ b/libkmod/libkmod-config.c > @@ -1,21 +1,7 @@ > +// SPDX-License-Identifier: LGPL-2.1-or-later > /* > - * libkmod - interface to kernel module operations > - * > - * Copyright (C) 2011-2013 ProFUSION embedded systems > - * Copyright (C) 2013 Intel Corporation. All rights reserved. > - * > - * This library is free software; you can redistribute it and/or > - * modify it under the terms of the GNU Lesser General Public > - * License as published by the Free Software Foundation; either > - * version 2.1 of the License, or (at your option) any later version. > - * > - * This library is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * Lesser General Puc License for more details. > - * > - * You should have received a copy of the GNU Lesser General Public > - * License along with this library; if not, see <http://www.gnu.org/licenses/>. > + * Copyright © 2011-2013 ProFUSION embedded systems > + * Copyright © 2013-2024 Intel Corporation > */ > The commit is few somewhat unrelated things. Since dealing with legalese is rarely fun, perhaps we can err on the verbose side and split things? Namely: - replaces license verbiage with SPDX one-liner - updates Intel copyright statement - would it make sense to your @intel email as author here? - (C) -> © update the ProFUSION copyright statement - LF's LFC191 [1] and SPDX [2] lists these as analogous to "Copyright" alone - drops the libkmod description one-liners Four commits might be an overkill - license vs rest should be good IMHO. Btw you can also use SPDX-FileCopyrightText [3]. HTH -Emil [1] https://training.linuxfoundation.org/training/open-source-licensing-basics-for-software-developers/ [2] https://spdx.github.io/spdx-spec/v2.3/license-matching-guidelines-and-templates/#b102-guideline [3] https://spdx.github.io/spdx-spec/v2.3/file-tags/
