Re: [PATCH v2 6/6] module: add install target for modules.builtin.ranges

[Masahiro Yamada <masahiroy@xxxxxxxxxx>]

On Mon, May 13, 2024 at 2:22 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Sun, May 12, 2024 at 7:59 AM Kris Van Hees <kris.van.hees@xxxxxxxxxx> wrote:
> >
> > When CONFIG_BUILTIN_MODULE_RANGES is enabled, the modules.builtin.ranges
> > file should be installed in the module install location.
> >
> > Signed-off-by: Kris Van Hees <kris.van.hees@xxxxxxxxxx>
> > Reviewed-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
> > ---
> > Changes since v1:
> >  - Renamed CONFIG_BUILTIN_RANGES to CONFIG_BUILTIN_MODULE_RANGES
> > ---
> >  scripts/Makefile.modinst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> > index b45586aa1de49..e185dacae892a 100644
> > --- a/scripts/Makefile.modinst
> > +++ b/scripts/Makefile.modinst
> > @@ -36,6 +36,11 @@ install-y += $(addprefix $(MODLIB)/, modules.builtin modules.builtin.modinfo mod
> >  $(addprefix $(MODLIB)/, modules.builtin modules.builtin.modinfo modules.builtin.objs): $(MODLIB)/%: % FORCE
> >         $(call cmd,install)
> >
> > +install-$(CONFIG_BUILTIN_MODULE_RANGES) += $(MODLIB)/modules.builtin.ranges
> > +
> > +$(MODLIB)/modules.builtin.ranges: modules.builtin.ranges FORCE
> > +       $(call cmd,install)
> > +
>
> Why add this to $(addprefix ...) part?


I meant, why don't you add this to $(addprefix ...)



Like this:


$(addprefix $(MODLIB)/, modules.builtin modules.builtin.modinfo
modules.builtin.ranges): $(MODLIB)/%: % FORCE
        $(call cmd,install)






-- 
Best Regards
Masahiro Yamada