Re: [PATCH] livepatch: Delete the associated module when replacing an old livepatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Apr 2, 2024, at 10:27, Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> 
> df1e98f2c74

Hi Yafang!

To my first question, from your patch, klp_free_patch_finish may not affect non-livpatch module. However, if my reading is right, your patch make changes to SYSCALL of delete_module. Making changes to sys call may effect non-livepatch module, I think.

Tell you the truth, in my production env, I don’t use klp replace mode because my livepatch fixing process dose’t adjust the logic of replacing the previous patches. Therefore, klp-replace mode is not suitable in my situation. The reason why I ask for safety is that this patch seems to change the syscall, which may cause some other effects.

For the commit ("kpatch: rmmod module of the same name before loading a module”) in patch userspace, it seems to fix this issue, while this commit is working in userspace, under kpatch’s control.  

What’s more, your patch seems to be malformed	when I try to patch it. Is there any thing wrong when I copying your patch?

This is only my own option in reading your patch. Thanks!

--
Regards
Warden






[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux