On Tue, 20 Feb 2024 at 22:11, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote:
>
> On Mon, Feb 12, 2024 at 05:07:57PM +0000, Emil Velikov via B4 Relay wrote:
> >From: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> >
> >The kmod insert/remove tools were introduced back in 2015. Since then
> >they have recieved zero attention, unlike the insmod/rmmod variants.
> >
> >Glancing around - neither of the following distributions (Arch, Fedora,
> >Gentoo, Debian) build them, so we're safe to say they have no users.
> >
> >Remove them and alongside it the --enable-experimental toggle, which no
> >longer controls anything.
> >
> >Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> >---
> >With the recent removal of the experimental and unmaintained python
> >bindings, I've noticed that we still have the insert/remove tools.
> >---
> > Makefile.am | 16 ---
> > configure.ac | 10 --
> > testsuite/.gitignore | 3 -
> > .../insert/lib/modules/4.4.4/modules.alias | 1 -
> > .../insert/lib/modules/4.4.4/modules.alias.bin | Bin 12 -> 0 bytes
> > .../insert/lib/modules/4.4.4/modules.builtin | 0
> > .../insert/lib/modules/4.4.4/modules.builtin.bin | Bin 12 -> 0 bytes
> > .../insert/lib/modules/4.4.4/modules.dep | 1 -
> > .../insert/lib/modules/4.4.4/modules.dep.bin | Bin 58 -> 0 bytes
> > .../insert/lib/modules/4.4.4/modules.devname | 1 -
> > .../insert/lib/modules/4.4.4/modules.order | 0
> > .../insert/lib/modules/4.4.4/modules.softdep | 1 -
> > .../insert/lib/modules/4.4.4/modules.symbols | 1 -
> > .../insert/lib/modules/4.4.4/modules.symbols.bin | Bin 12 -> 0 bytes
> > .../remove/lib/modules/4.4.4/modules.alias | 1 -
> > .../remove/lib/modules/4.4.4/modules.alias.bin | Bin 12 -> 0 bytes
> > .../remove/lib/modules/4.4.4/modules.builtin | 0
> > .../remove/lib/modules/4.4.4/modules.builtin.bin | Bin 12 -> 0 bytes
> > .../remove/lib/modules/4.4.4/modules.dep | 1 -
> > .../remove/lib/modules/4.4.4/modules.dep.bin | Bin 58 -> 0 bytes
> > .../remove/lib/modules/4.4.4/modules.devname | 1 -
> > .../remove/lib/modules/4.4.4/modules.order | 0
> > .../remove/lib/modules/4.4.4/modules.softdep | 1 -
> > .../remove/lib/modules/4.4.4/modules.symbols | 1 -
> > .../remove/lib/modules/4.4.4/modules.symbols.bin | Bin 12 -> 0 bytes
> > .../sys/module/mod_simple/holders/.gitignore | 0
> > .../remove/sys/module/mod_simple/initstate | 1 -
> > .../test-tools/remove/sys/module/mod_simple/refcnt | 1 -
> > testsuite/setup-rootfs.sh | 2 -
> > testsuite/test-tools.c | 71 ----------
> > tools/insert.c | 128 -----------------
> > tools/kmod.c | 5 -
> > tools/remove.c | 153 ---------------------
> > 33 files changed, 400 deletions(-)
>
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.alias.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.alias.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.builtin.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.builtin.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.dep.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.dep.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.symbols.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/insert/lib/modules/4.4.4/modules.symbols.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.alias.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.alias.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.builtin.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.builtin.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.dep.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.dep.bin: patch does not apply
> error: cannot apply binary patch to 'testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.symbols.bin' without full index line
> error: testsuite/rootfs-pristine/test-tools/remove/lib/modules/4.4.4/modules.symbols.bin: patch does not apply
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
>
>
> something is wrong with either b4 when there are binary patches or in
> your git config. I applied the other hunks and removed
> testsuite/rootfs-pristine/test-tools/{insert,remove} manually.
>
Sorry about that - will fix this for the next round of patches.
-Emil
