Le 16/02/2024 à 20:28, Kees Cook a écrit : > On Fri, Feb 16, 2024 at 09:14:27AM +0100, Christophe Leroy wrote: >> set_memory_ro(), set_memory_nx(), set_memory_x() and other helpers >> can fail and return an error. In that case the memory might not be >> protected as expected and the module loading has to be aborted to >> avoid security issues. >> >> Check return value of all calls to set_memory_XX() and handle >> error if any. >> >> Add a check to not call set_memory_XX() on NULL pointers as some >> architectures may not like it allthough numpages is always 0 in that >> case. This also avoid a useless call to set_vm_flush_reset_perms(). >> >> Link: https://github.com/KSPP/linux/issues/7 >> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx> > > Yay! Glad to see this happening. Universal __must_check for set_memory_*() > starts to appear on the horizon. ;) > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > Thanks I also sent 3 patches to powerpc, I forgot to copy you but I put the links in https://github.com/KSPP/linux/issues/7 Christophe
