Re: Re: [PATCH 2/2] make: install/uninstall tools symlinks to kmod

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 29, 2024 at 05:23:44PM +0000, Emil Velikov wrote:
On Mon, 29 Jan 2024 at 16:40, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote:

On Fri, Jan 26, 2024 at 02:43:51PM +0000, Emil Velikov via B4 Relay wrote:
>From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
>
>Currently we create symlinks like modprobe (pointing to kmod), during
>the normal `make` build. Although those were never installed.
>
>Add a few lines in the install-exec-hook, to ensure they're present at
>`make install` time. Thus one can actually use those without additional
>changes. As an added bonus, distributions can drop the similar hunk from
>their packaging.

It was a long time ago and my memory may be fading, but afair the fact
that distros were doing it was what prevented us from adding the
symlinks ourselves.... and then we never re-visited this.

I'll dig some history before applying to make sure I'm not forgetting
something.

Ack, makes sense. Fwiw I've already opened a MR with the Arch team
highlighting these changes.

no wonder my memory faded as it was almost 12 years ago and during  kmod 3 ~ 5.


00fc926 build-sys: create symlinks instead of building separate tools

	when we started using symlinks to a single kmod binary

7bbf523 build-sys: create symlinks if we are installing tools
12fd9cd build-sys: forcefully create links

	when we started creating the symlinks

fe8b067 build-sys: do not create symlinks by default

	stop creating the symlinks since it was not working across
	distros and creating more problems than solving

Now that distros configure all the paths through configure options,
we can probably re-attempt this.

Cc'ing some pkg maintainers


Lucas De Marchi


Sadly I don't have contact for other maintainers.

>
>Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
>---
>Out of curiosity: are there any plans about releasing v32? I'm
>interested in the recent /usr/lib/modules (module_directory) patches.


yes, I should be releasing that soon, probably this week or the next.


Thanks much appreciated.
Emil




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux