[ Going through my "this is still pending" list ]
On Wed, 10 Jan 2024 at 02:24, Russell King (Oracle)
<rmk+kernel@xxxxxxxxxxxxxxx> wrote:
>
> I don't know what the minimum requirement is for SHA3 to work, so I have
> chosen a minimum of version 29 for the purposes of this patch.
I see that there is some noise about hopefully just getting depmod fixed.
But if we take this approach and just say "don't allow SHA3 signing
with a broken depmod", I'd personally be happier with something that
isn't version-dependent, but is bug-dependent.
IOW, instead of doing "depmod --version" and parsing that,
particularly since apparently the exact version isn't clear, would it
be possible to just actually test for the bug itself?
Or, honestly, maybe just extend the depmod wrapper script to write our
a more descriptive error report. We already have that whole
echo "Warning: 'make modules_install' requires $DEPMOD. Please
install it." >&2
thing, so we already have run-time error handling (although I note
that it does "exit 0" instead of something saner) rather than some
Kconfig-time case.
Linus
