Re: [PATCH] modprobe: prefer -ENODATA over -ENOENT if no section found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 19/05/2023 à 09:03, Dmitry Antipov a écrit :
> On 5/19/23 09:52, Christophe Leroy wrote:
> 
>> Fine, but can you show the text message modprobe provides with your
>> change, so that we can see if the change provides a somewhat better less
>> confusing message ?
> 
> Sure, now it is expected to be:
> 
> $ modprobe --dump-modversions 
> /lib/modules/6.2.15-300.fc38.x86_64/extra/crystalhd/crystalhd.ko.xz
> modprobe: FATAL: could not get modversions of 
> /lib/modules/6.2.15-300.fc38.x86_64/extra/crystalhd/crystalhd.ko.xz: No 
> data available
> 
> I'm not insisting on -ENODATA, but IMO -ENOENT is not suitable in this 
> case at all.
> 

I'm fine with that, just wanted know what the message is now.

Can you had the information in the commit message ?

With that added:

Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux