On Thu, Apr 13, 2023 at 10:28:38PM -0700, Luis Chamberlain wrote: > At first I wondered if > we could use file descriptor hints to just exlude users early on boot > before SYSTEM_RUNNING. I couldn't find much, but if there are some ways > to do that -- then the last patch can be simplified to do just that. > The second patch proves essentially that we can just send -EBUSY to > duplicate requests, at least for duplicate module loads and the world > doesn't fall apart. It *would* solve the issue. The patch however > borrows tons of the code from the first, and if we're realy going to > rely on something like that we may as well share. But I'm hopeful that > perhaps there are some jucier file descriptor tricks we can use to > just make a file mutually exlusivive and introduce a new kread which > lets finit_module() use that. The saving grace is that at least all > finit_module() calls *wait*, contray to request_module() calls and so > the solution can be much simpler. > > The end result is 0 wasted virtual memory bytes. > > Any ideas how not to make patch 2 suck as-is ? The more I think about it, a file descriptor based approach would have to loop over all tasks as we're not sure if userspace would use the same thread and just fork requests or what. One would then have to loop over all tasks and look for files that match the same name. This approach is domain specific to internal kernel reads and I am thinking now it is more appropriate. Since this is a bootup issue for races with module loading what we could do is just have say kernel_read_file_from_fd_excl() which would just call a shared __kernel_read_file_from_fd(..., bool excl, ...) and the kernel_read_file_from_fd() could just set that excl to false while the new one sets it to true. Then finit_module() could just use that. Luis
