On Wed, Mar 29, 2023 at 03:51:37PM +0200, Nicolas Schier wrote:
Add a test for 'modprobe --remove --remove-holders' and a simple dependency module chain of three modules. Signed-off-by: Nicolas Schier <n.schier@xxxxxx> --- Changes in v2: * new patch --- testsuite/module-playground/Makefile | 6 +++ testsuite/module-playground/mod-dep-chain-a.c | 21 ++++++++ testsuite/module-playground/mod-dep-chain-b.c | 22 +++++++++ testsuite/module-playground/mod-dep-chain-c.c | 22 +++++++++ testsuite/module-playground/mod-dep-chain.h | 8 +++ .../remove-holders/lib/modules/6.2/modules.alias | 1 + .../lib/modules/6.2/modules.alias.bin | Bin 0 -> 12 bytes .../lib/modules/6.2/modules.builtin.alias.bin | 0 .../lib/modules/6.2/modules.builtin.bin | 0 .../remove-holders/lib/modules/6.2/modules.dep | 3 ++ .../remove-holders/lib/modules/6.2/modules.dep.bin | Bin 0 -> 229 bytes .../remove-holders/lib/modules/6.2/modules.devname | 0 .../remove-holders/lib/modules/6.2/modules.softdep | 1 + .../remove-holders/lib/modules/6.2/modules.symbols | 4 ++ .../lib/modules/6.2/modules.symbols.bin | Bin 0 -> 143 bytes .../test-modprobe/remove-holders/proc/modules | 3 ++ .../sys/module/mod_dep_chain_a/coresize | 1 + .../module/mod_dep_chain_a/holders/mod_dep_chain_b | 1 + .../sys/module/mod_dep_chain_a/initsize | 1 + .../sys/module/mod_dep_chain_a/initstate | 1 + .../sys/module/mod_dep_chain_a/notes/.note.Linux | Bin 0 -> 60 bytes .../mod_dep_chain_a/notes/.note.gnu.build-id | Bin 0 -> 36 bytes .../sys/module/mod_dep_chain_a/refcnt | 1 + .../sections/.gnu.linkonce.this_module | 1 + .../sys/module/mod_dep_chain_a/sections/.init.data | 1 + .../module/mod_dep_chain_a/sections/.note.Linux | 1 + .../mod_dep_chain_a/sections/.note.gnu.build-id | 1 + .../module/mod_dep_chain_a/sections/.orc_unwind | 1 + .../module/mod_dep_chain_a/sections/.orc_unwind_ip | 1 + .../module/mod_dep_chain_a/sections/.return_sites | 1 + .../module/mod_dep_chain_a/sections/.rodata.str1.1 | 1 + .../sys/module/mod_dep_chain_a/sections/.strtab | 1 + .../sys/module/mod_dep_chain_a/sections/.symtab | 1 + .../module/mod_dep_chain_a/sections/.text.unlikely | 1 + .../sys/module/mod_dep_chain_a/sections/__kcrctab | 1 + .../sys/module/mod_dep_chain_a/sections/__ksymtab | 1 + .../mod_dep_chain_a/sections/__ksymtab_strings | 1 + .../module/mod_dep_chain_a/sections/__mcount_loc | 1 + .../sys/module/mod_dep_chain_a/taint | 1 + .../sys/module/mod_dep_chain_b/coresize | 1 + .../module/mod_dep_chain_b/holders/mod_dep_chain_c | 1 + .../sys/module/mod_dep_chain_b/initsize | 1 + .../sys/module/mod_dep_chain_b/initstate | 1 + .../sys/module/mod_dep_chain_b/notes/.note.Linux | Bin 0 -> 60 bytes .../mod_dep_chain_b/notes/.note.gnu.build-id | Bin 0 -> 36 bytes .../sys/module/mod_dep_chain_b/refcnt | 1 + .../sections/.gnu.linkonce.this_module | 1 + .../sys/module/mod_dep_chain_b/sections/.init.data | 1 + .../module/mod_dep_chain_b/sections/.note.Linux | 1 + .../mod_dep_chain_b/sections/.note.gnu.build-id | 1 + .../module/mod_dep_chain_b/sections/.orc_unwind | 1 + .../module/mod_dep_chain_b/sections/.orc_unwind_ip | 1 + .../module/mod_dep_chain_b/sections/.return_sites | 1 + .../module/mod_dep_chain_b/sections/.rodata.str1.8 | 1 + .../sys/module/mod_dep_chain_b/sections/.strtab | 1 + .../sys/module/mod_dep_chain_b/sections/.symtab | 1 + .../module/mod_dep_chain_b/sections/.text.unlikely | 1 + .../sys/module/mod_dep_chain_b/sections/__kcrctab | 1 + .../sys/module/mod_dep_chain_b/sections/__ksymtab | 1 +
I think it would be ok to drop */sections and */notes/ since libkmod doesn't care about them. Otherwise looks good to me: Reviewed-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> thanks Lucas De Marchi
