Re: [PATCH] stress-module: stress finit_module() and delete_module()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just some comments on the code that feel a little bit odd to me, 
while I was reading the code.

> +#if defined(HAVE_LINUX_MODULE_H)
> +#include <linux/module.h>
> +#else
> +UNEXPECTED
> +#endif
> +
> +#if defined(HAVE_LIBGEN_H)
> +#include <libgen.h>
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_MODVERSIONS
> +# define MODULE_INIT_IGNORE_MODVERSIONS 1
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_VERMAGIC
> +# define MODULE_INIT_IGNORE_VERMAGIC 2
> +#endif
looks like that the #define has an exstra space and this differ from the others 
.[c,h] files?

➜  stress-ng git:(master) ✗ git grep "#define" | wc -l
2830
➜  stress-ng git:(master) ✗ git grep "# define" | wc -l
1

Cheers!

Vincent.




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux