Hi Nick,
On Thu, Mar 2, 2023 at 11:25 PM Nick Alcock <nick.alcock@xxxxxxxxxx> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
> Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/bus/simple-pm-bus.c
> +++ b/drivers/bus/simple-pm-bus.c
> @@ -92,4 +92,3 @@ module_platform_driver(simple_pm_bus_driver);
>
> MODULE_DESCRIPTION("Simple Power-Managed Bus Driver");
> MODULE_AUTHOR("Geert Uytterhoeven <geert+renesas@xxxxxxxxx>");
> -MODULE_LICENSE("GPL v2");
Please do not remove this line as long as the file has no SPDX-License
tag.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
