Hi Nick, Looks good to me. Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx> On Tue, 2023-02-28 at 13:02 +0000, Nick Alcock wrote: > [Some people who received this message don't often get email from > nick.alcock@xxxxxxxxxx. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ;] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx> > Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> > Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx> > Cc: linux-modules@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: Hitomi Hasegawa <hasegawa-hitomi@xxxxxxxxxxx> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Cc: Lars Povlsen <lars.povlsen@xxxxxxxxxxxxx> > Cc: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx> > Cc: Daniel Machon <daniel.machon@xxxxxxxxxxxxx> > Cc: UNGLinuxDriver@xxxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > --- > drivers/reset/reset-microchip-sparx5.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/reset/reset-microchip-sparx5.c b/drivers/reset/reset- > microchip-sparx5.c > index f3528dd1d084e..ead25942061d2 100644 > --- a/drivers/reset/reset-microchip-sparx5.c > +++ b/drivers/reset/reset-microchip-sparx5.c > @@ -179,4 +179,3 @@ postcore_initcall(mchp_sparx5_reset_init); > > MODULE_DESCRIPTION("Microchip Sparx5 switch reset driver"); > MODULE_AUTHOR("Steen Hegelund <steen.hegelund@xxxxxxxxxxxxx>"); > -MODULE_LICENSE("Dual MIT/GPL"); > -- > 2.39.1.268.g9de2f9a303 > BR Steen
