Re: [PATCH] module: Remove the unused function within

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+Cc: Song

Nathan Chancellor writes:
On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
Jiapeng Chong writes:
> The function within is defined in the main.c file, but not called
> elsewhere, so remove this unused function.

Huh? It's used by __module_text_address(), no?

Not after commit 2ece476a2346 ("module: replace module_layout with
module_memory") in -next. This patch should have a fixes tag, even if
the warning is currently hidden behind W=1.

Huh, I thought I had checked out latest -next, but must have not done so somehow :-) Mea culpa.

If it's only in -next then no Fixes needed, since there's no stable rev yet.

Jiapeng, in future, please make sure to cc the author of related commits when reporting stuff like this :-) It helps people to update their patches.

Song, you probably want to update your patch.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux