On Thu, 9 Feb 2023 at 19:20, Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> wrote: > > Instead of skipping tests if sysconfdir isn't /etc, just handle it > during the rootfs setup logic. > Nice. I'm far from an expert in the kmod codebase but the series looks good IMHO. For the two: Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> SIde note: while looking through the Makefile.am I've noticed we're doig manual SED substitution. Didn't look too closely but it should be possible to: - add respective files to the AC_CONFIG_FILES section (barring .in suffix) - drop the explicit makefile rules, sed command and extra_dist/cleanfiles Don't think I'll have the time to submit a patch, I'm literally on the train right now heading out for a while. HTH Emil
