On Mon, Jan 16, 2023 at 11:10:07AM +0100, Jiri Olsa wrote: > From: Zhen Lei <thunder.leizhen@xxxxxxxxxx> > > Currently we traverse all symbols of all modules to find the specified > function for the specified module. But in reality, we just need to find > the given module and then traverse all the symbols in it. > > Let's add a new parameter 'const char *modname' to function > module_kallsyms_on_each_symbol(), then we can compare the module names > directly in this function and call hook 'fn' after matching. If 'modname' > is NULL, the symbols of all modules are still traversed for compatibility > with other usage cases. > > Phase1: mod1-->mod2..(subsequent modules do not need to be compared) > | > Phase2: -->f1-->f2-->f3 > > Assuming that there are m modules, each module has n symbols on average, > then the time complexity is reduced from O(m * n) to O(m) + O(n). > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> > Acked-by: Song Liu <song@xxxxxxxxxx> > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> I'm happy for folks to take this through another tree. I was merging kallsysm stuff on the modules tree to avoid conflicts with Nick Alcock's work but after reviewing his v10 series it is quite clear that's no where near ready now and I don't expect much conflicts even if it was. Luis
