Add sysfs match-id modalias attribute for USB modules This patch series (v6) exposes the driver matching values from the modalias to inform policy decisions in userspace for devices with the authorized attribute in sysfs. In other words with this patch tools like USBGuard could leverage not only modules.aliases, but also the aliases for the builtin modules to associate devices with modules that may be bound before deciding to authorize a device or not. This is particularly useful in cases when new devices shouldn't be allowed part of the time like for lock screens. Note that at this point the series only implements USB, but Thunderbolt and other subsystems could be added. CONFIG_SYSFS and CONFIG_MODULES (adds /sys/module/) are both required for the /sys/module/*/modalias attributes to be present. -- # Module sysfs modalias attribute for match ids Note that previous versions of this patch series were flattened into a single patch, and a cover letter was first added in v5 with diffs between each previous version of the patch series. Also this version adds a `Documentation/ABI` entry for `/sys/module/*/modalias`. RFC (broken patch): https://lore.kernel.org/lkml/CAJzde042-M4UbpNYKw0eDVg4JqYmwmPYSsmgK+kCMTqsi+-2Yw@xxxxxxxxxxxxxx/ v1 (missing v1 label): https://lore.kernel.org/lkml/20221111152852.2837363-1-allenwebb@xxxxxxxxxx/ v2 (missing v2 label): https://lore.kernel.org/lkml/20221128201332.3482092-1-allenwebb@xxxxxxxxxx/ v3: https://lore.kernel.org/lkml/20221129224313.455862-1-allenwebb@xxxxxxxxxx/ v4: https://lore.kernel.org/lkml/20221130221447.1202206-1-allenwebb@xxxxxxxxxx/ v5: https://lore.kernel.org/lkml/20221201211630.101541-1-allenwebb@xxxxxxxxxx/ v6: This version ## Patch series status This series is still going through revisions in response to comments. USB is the only implemented subsystem, but PCI or other subsystems with the authorized attribute could be added. There is still an open question as to whether using kmod would be a better approach to solve the problem. One big hurdle with that approach is match-id-based aliases are not currently exposed through kmod and changing that behavior might have unintended consequences. The particular concerns I have are: - Are we OK with significantly growing the number of aliases handled by kmod by including the match-id-based aliases? - Are other tools that use kmod prepared to handle the addition of match-id-based aliases? - Additional work would be needed for kmod to be able to handle match-id-based aliases and it would likely require subsystem specific elements unless it leveraged files2alias. Also, `mod_devicetable.c` is very similar to files2alias, so there might be some possiblity of having common logic between the two. The big difficulty lies in support both use cases which need to work both at build time and at runtime. Additionally before this is ready, there should be implementations for the other subsystems whose devices have the `authorized` sysfs attribute (Thunderbolt). ## Acknowledgements Thanks to Greg Kroah-Hartman and the Linux maintainers for being patient with me as I have worked through learning the kernel workflow to get this series into a more presentable state. Thanks to Luis Chamberlain for raising the alternative of using kmod to address the primary motivation of the patch series. Also, thanks to Intel's kernel test robot <lkp@xxxxxxxxx> for catching issues that showed up on different kernel configurations. Allen Webb (5): module: Add empty modalias sysfs attribute drivers: Add bus_for_each for iterating over the subsystems Implement modalias sysfs attribute for modules docs: Add entry for /sys/module/*/modalias drivers: Implement module modaliases for USB Documentation/ABI/testing/sysfs-module | 12 ++ drivers/base/Makefile | 2 +- drivers/base/base.h | 8 + drivers/base/bus.c | 42 ++++ drivers/base/mod_devicetable.c | 257 +++++++++++++++++++++++++ drivers/usb/core/driver.c | 2 + include/linux/device/bus.h | 8 + include/linux/module.h | 1 + kernel/module/internal.h | 2 + kernel/module/sysfs.c | 88 +++++++++ kernel/params.c | 7 + 11 files changed, 428 insertions(+), 1 deletion(-) create mode 100644 drivers/base/mod_devicetable.c -- 2.37.3
