On Mon, Nov 21, 2022 at 03:21:10PM +0000, Nick Alcock wrote: > One question: do you think it's worthwhile me submitting patches to > de-MODULE_* things that need it? 100% yes. Yes please remove all that module declration helpers for things that are not modules, and after you add your helper which will nag at build time when it finds new ones. For justification just mention in the commit log that after commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf") we rely on the module license tag to generate the modules.builtin file and so built-in code which uses module helpers just need to be removed. Luis