On 9/30/22 22:30, Luis Chamberlain wrote:
> On Mon, Sep 19, 2022 at 02:32:33PM +0200, Petr Pavlu wrote:
>> During a system boot, it can happen that the kernel receives a burst of
>> requests to insert the same module but loading it eventually fails
>> during its init call.
>
> Please take a look at kmod selftest lib/test_kmod.c and the respective shell
> selftest tools/testing/selftests/kmod/kmod.sh. Can you modify it to add
> support to reproduce this issue?
It was possible for me to write some kselftests for this. I will post them as
a separate patch in v3.
>> For instance, udev can make a request to insert
>> a frequency module for each individual CPU
>
> That seems stupid indeed, it would seem we should be able for sure to prevent
> such cases, it can't just be happening for frequency modules.
The issue was also observed with EDAC drivers which are similarly exclusive.
>> Note that prior to 6e6de3dee51a ("kernel/module.c: Only return -EEXIST
>> for modules that have finished loading"), the kernel already did merge
>> some of same load requests but it was more by accident and relied on
>> specific timing. The patch brings this behavior back in a more explicit
>> form.
>
> I'm having a hard time with this, because it is not clear if you are
> suggesting this is a regression introduced by 6e6de3dee51a or not. I'd
> like you to evaluate the impact of *not* merging a fix to older kernels.
> In practice I think we'd end up with delays on boot, but is that all?
> Would boot ever fail? The commit log does not make that clear.
>
> The commit log should make it clear if this a regression or not and the
> impact of not having these fixes merged. Please not that bots will try
> to scrape for fixes and I suspect bots will pour their heart out on this
> commit log and identify and assume this if a fix already as-is.
I touched on this somewhat in my response to review comments on v1 from Petr
Mladek [1] but it looks I failed to appropriately update the commit message
in the new version. I will try to improve it in v3.
The patch does address a regression observed after commit 6e6de3dee51a
("kernel/module.c: Only return -EEXIST for modules that have finished
loading"). I guess it can have a Fixes tag added to the patch.
To add more information, the following is a test from a machine with 288 CPUs
which I performed when preparing this patch. The system had Tumbleweed
20220829 installed on it. The boot process tried to load 288x pcc_cpufreq and
576x acpi_cpufreq modules which all failed because intel_pstate was already
active.
The test used three custom builds. The base was 6.0-rc3, 'revert' is
base + revert of 6e6de3dee51a, 'my' is base + the proposed fix. Compiled
modules were uncompressed and unsigned.
Each configuration had its boot tested 5 times. Time was measured from the
first load attempt of a given module to the last one, by simply looking at
messages such as "Inserted module 'acpi_cpufreq'" in the udev log and their
timestamps. All times are in seconds.
| | Configuration |
| Boot | base | revert | my |
| v | pcc | acpi | pcc | acpi | pcc | acpi |
+------+--------+--------+--------+--------+--------+--------+
| #1 | 45.374 | 45.462 | 1.992 | 8.509 | 2.190 | 6.931 |
| #2 | 44.727 | 44.712 | 2.249 | 11.436 | 1.821 | 8.413 |
| #3 | 45.450 | 45.771 | 1.685 | 8.784 | 1.964 | 6.341 |
| #4 | 44.306 | 44.840 | 2.469 | 9.611 | 2.362 | 6.856 |
| #5 | 45.132 | 45.216 | 2.063 | 8.782 | 1.717 | 6.405 |
+------+--------+--------+--------+--------+--------+--------+
| Avg | 44.998 | 45.200 | 2.092 | 9.424 | 2.011 | 6.989 |
This shows the observed regression and results with the proposed fix.
> If this *is* a regression, we should try to see how perhaps we can split
> this up into a part which is mergable to stable and then a secondary
> part which does some new fancy optimizations.
I think it is hard to split this patch into parts because the implemented
"optimization" is the fix.
[1] https://lore.kernel.org/linux-modules/0ccb384f-bbd5-f0fd-3832-c2255df505b2@xxxxxxxx/
Thanks,
Petr
