> -----Original Message----- > From: Elliott, Robert (Servers) <elliott@xxxxxxx> > Sent: Monday, October 10, 2022 10:12 AM > To: Aaron Tomlin <atomlin@xxxxxxxxxx>; linux-modules@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Unloaded tainted modules list with tcrypt > > When repeatedly using the tcrypt module (which is designed to never > load successfully), the "Unloaded tainted modules" list grows forever: > > Unloaded tainted modules: tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 > tcrypt():1 tcrypt():1 padlock_aes():1 padlock_aes():1 > isst_if_mbox_msr():1 acpi_cpufreq():1 pcc_cpufreq():1 isst_if_mbox_msr():1 > acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 acpi_cpufreq():1 > pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1 > pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1 > isst_if_mbox_msr():1 isst_if_mbox_msr():1 > acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 isst_if_mbox_msr():1 > > Some other modules like acpi_cpufreq() are repeated too. > > Maybe this check after the name comparison: > mod_taint->taints & mod->taints > should be: > mod_taint->taints == mod->taints > > or shouldn't be there at all? Changing to == seems to work well - that shows incremented counts rather than new entries: Unloaded tainted modules: tcrypt():40 padlock_aes():1 isst_if_mbox_msr():56 pcc_cpufreq():56 acpi_cpufreq():112
