On Wed, Aug 31, 2022 at 01:46:29PM -0400, Kent Overstreet wrote: > Because all the counters are statically allocated, without even a pointer deref > to get to them in the allocation path (one pointer deref to get to them in the > deallocate path), that makes this _much, much_ cheaper than anything that could > be done with tracing - cheap enough that I expect many users will want to enable > it in production. You're contributing to death-by-a-thousand-cuts here. By making all this unconditional you're putting distros in a bind. Most of their users will likely not care about this, but if they enable it, they'll still pay the price for having it. Even static counters will have cache misses etc.. So yes, for the few people that actually care about this stuff, this might be a bit faster, but IMO it gets the econimics all backwards, you're making everybody pay the price instead of only those that care. Also note that you can have your tracepoint based handler have statically allocated data just fine.
