Re: [PATCH modules-next] module: Add debugfs interface to view unloaded tainted modules

[Petr Pavlu <petr.pavlu@xxxxxxxx>]

On 8/23/22 21:32, Aaron Tomlin wrote:
> [...]
> @@ -59,3 +60,68 @@ void print_unloaded_tainted_modules(void)
>  		}
>  	}
>  }
> +
> +#ifdef CONFIG_DEBUG_FS
> +static void *unloaded_tainted_modules_seq_start(struct seq_file *m, loff_t *pos)
> +{
> +	mutex_lock(&module_mutex);
> +	return seq_list_start_rcu(&unloaded_tainted_modules, *pos);
> +}

unloaded_tainted_modules looks to be a proper RCU list which makes me think
this reader could use just rcu_read_lock() instead of
mutex_lock(&module_mutex)?

Thanks,
Petr