On Sun, 3 Jul 2022 17:58:15 +0000 Christophe Leroy <christophe.leroy@xxxxxxxxxx> wrote: > When I started submitting Kernel patches years ago, I was given those > guidelines: > - Always submit checkpatch clean patches. > - Try to never modify the same line of code twice in a series. > > Which implied to always fix codying Style while changing or moving code. Yeah, I figured as much. I'll go back and read the coding style and see if it mentions this. If not, it needs to be updated. The exception is when you move code. Code moving should never have any other changes to it, because it makes it much more difficult to know what changed. -- Steve