[PATCH v1] module: Fix prefix for module.sig_enforce module param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Commit cfc1d277891e ("module: Move all into module/") changed the prefix
of the module param by moving/renaming files. A later commit also moves
the module_param() into a different file, thereby changing the prefix
yet again.

This would break kernel cmdline compatibility and also userspace
compatibility at /sys/module/module/parameters/sig_enforce.

So, set the prefix back to "module.".

Cc: Aaron Tomlin <atomlin@xxxxxxxxxx>
Cc: mcgrof@xxxxxxxxxx
Cc: christophe.leroy@xxxxxxxxxx
Cc: cl@xxxxxxxxx
Cc: mbenes@xxxxxxx
Cc: akpm@xxxxxxxxxxxxxxxxxxxx
Cc: jeyu@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-modules@xxxxxxxxxxxxxxx
Cc: void@xxxxxxxxxxxxx
Cc: atomlin@xxxxxxxxxxx
Cc: allen.lkml@xxxxxxxxx
Cc: joe@xxxxxxxxxxx
Cc: msuchanek@xxxxxxx
Cc: oleksandr@xxxxxxxxxxxxxx
Cc: jason.wessel@xxxxxxxxxxxxx
Cc: pmladek@xxxxxxxx
Cc: daniel.thompson@xxxxxxxxxx
Cc: hch@xxxxxxxxxxxxx
Fixes: cfc1d277891e ("module: Move all into module/")
Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
---
Sending this patch in case my analysis in [1] was right.

[1] - https://lore.kernel.org/lkml/20220602034111.4163292-1-saravanak@xxxxxxxxxx/

-Saravana

 kernel/module/signing.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/module/signing.c b/kernel/module/signing.c
index 85c8999dfecf..6b0672e4417b 100644
--- a/kernel/module/signing.c
+++ b/kernel/module/signing.c
@@ -16,6 +16,11 @@
 #include <uapi/linux/module.h>
 #include "internal.h"
 
+#ifdef MODULE_PARAM_PREFIX
+#undef MODULE_PARAM_PREFIX
+#endif
+#define MODULE_PARAM_PREFIX "module."
+
 static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
 module_param(sig_enforce, bool_enable_only, 0644);
 
-- 
2.36.1.255.ge46751e96f-goog




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux