Re: [PATCH v5 00/12] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2022 at 5:04 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> Hi Masahiro,
>
> On Thu, May 12, 2022 at 01:45:02AM +0900, Masahiro Yamada wrote:
> >
> > This is the third batch of cleanups in this development cycle.
> >
> > Major changes in v5:
> >  - Fix build errors
> >  - More cleanups
> >
> > Major changes in v4:
> >  - Move static EXPORT_SYMBOL check to a script
> >  - Some refactoring
> >
> > Major changes in v3:
> >
> >  - Generate symbol CRCs as C code, and remove CONFIG_MODULE_REL_CRCS.
> >
> > Major changes in v2:
> >
> >  - V1 did not work with CONFIG_MODULE_REL_CRCS.
> >    I fixed this for v2.
> >
> >  - Reflect some review comments in v1
> >
> >  - Refactor the code more
> >
> >  - Avoid too long argument error
> >
> >
> >
> > Masahiro Yamada (12):
> >   modpost: split the section mismatch checks into section-check.c
> >   modpost: add sym_find_with_module() helper
> >   modpost: extract symbol versions from *.cmd files
> >   kbuild: link symbol CRCs at final link, removing
> >     CONFIG_MODULE_REL_CRCS
> >   kbuild: stop merging *.symversions
> >   genksyms: adjust the output format to modpost
> >   kbuild: do not create *.prelink.o for Clang LTO or IBT
> >   kbuild: check static EXPORT_SYMBOL* by script instead of modpost
> >   kbuild: make built-in.a rule robust against too long argument error
> >   kbuild: make *.mod rule robust against too long argument error
> >   kbuild: add cmd_and_savecmd macro
> >   kbuild: rebuild multi-object modules when objtool is updated
>
> I applied this series to your latest kbuild branch, built an Arch
> Linux x86_64 config and Fedora aarch64 config with
> CONFIG_LTO_CLANG_FULL=y then CONFIG_LTO_CLANG_THIN=y, and boot tested
> each kernel in QEMU with a full userspace. I did not notice any new
> warnings/errors and everything appears to work fine.
>
> Tested-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>
> Cheers,
> Nathan


Thanks for your testing.

I ended up with v6 due to a build issue
of CONFIG_TRIM_UNUSED_KSYMS,
but this patch set is getting in good shape.

Thanks.


-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux