On Tue, Apr 26, 2022 at 09:39:30AM +0100, Aaron Tomlin wrote: > On Mon 2022-04-25 16:31 -0700, Luis Chamberlain wrote: > > This all looks good except with all the work you did to remove > > #ifdef hell, it gets me wondering why not just use a new file for this? > > > > What does that look like? > > Hi Luis, > > I thought about it. It is indeed possible. Yet, I do not think it is worth > it, for such a small change; albeit, what do you prefer? I'd rather see the effort than not, given all the effort to already split things. I think it keeps things pretty tidy and it can scale / and its easier to review. Luis
