On Thu, 21 Apr 2022, Aaron Tomlin wrote: > > > + if (len == strlen(mod->name) && !memcmp(mod_taint->name, mod->name, len) && > > > > Here, two strings are compared, so I'd expect to see `strncmp()` instead of `memcmp()`. > > Good point. There are other examples of this throughout > kernel/module/main.c; albeit, I will use strncmp() here. Comparing the length first may be an attempt to avoid the expensive memcmp. But here we need to first execute strlen() to obtain the string length. This is already accessing all characters so this check is wasteful and a straight str[n]cmp is better.
